Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[benchmark] Allows benchmark run on aarch64 for PyTorch #1591

Merged
merged 1 commit into from
Apr 20, 2022
Merged

[benchmark] Allows benchmark run on aarch64 for PyTorch #1591

merged 1 commit into from
Apr 20, 2022

Conversation

frankfliu
Copy link
Contributor

Change-Id: Ic598d884e63eedafaf4539295b9b927cc73479ac

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu
[benchmark] Allows benchmark run on aarch64 for PyTorch
7aba25c 
Change-Id: Ic598d884e63eedafaf4539295b9b927cc73479ac
@frankfliu frankfliu requested a review from zachgk as a code owner April 20, 2022 19:55
@codecov-commenter
Copy link

Codecov Report

Merging #1591 (7aba25c) into master (bb5073f) will decrease coverage by 1.21%.
The diff coverage is 60.57%.

@@             Coverage Diff              @@
##             master    #1591      +/-   ##
============================================
- Coverage     72.08%   70.87%   -1.22%     
- Complexity     5126     5400     +274     
============================================
  Files           473      504      +31     
  Lines         21970    23608    +1638     
  Branches       2351     2566     +215     
============================================
+ Hits          15838    16731     +893     
- Misses         4925     5599     +674     
- Partials       1207     1278      +71
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <ø> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../modality/cv/translator/YoloTranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...i/djl/modality/cv/translator/YoloV5Translator.java 5.69% <0.00%> (ø)
...odality/cv/translator/YoloV5TranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...pi/src/main/java/ai/djl/ndarray/BytesSupplier.java 54.54% <0.00%> (-12.13%) ⬇️
...ain/java/ai/djl/ndarray/index/dim/NDIndexPick.java 100.00% <ø> (ø)
api/src/main/java/ai/djl/nn/Blocks.java 75.00% <0.00%> (-25.00%) ⬇️
... and 235 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 077eb40...7aba25c. Read the comment docs.

@frankfliu frankfliu merged commit bbdcbf7 into deepjavalibrary:master Apr 20, 2022
@frankfliu frankfliu deleted the bench branch April 20, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankfliu @codecov-commenter @lanking520